{Misc.} Do not get latest version from GitHub if possible #30671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
bebound
requested review from
jiasli,
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy and
necusjz
as code owners
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supplement of #30643
It's not necessary to get latest version from GitHub if
versionCheck.jsonis not available. This PR change the behavior ofAzCli, all other logic remains unchanged.az -valways gets the latest version from GitHub withget_az_version_string()az xxx -hcallsshow_updates_available->get_az_version_string(use_cache=True), with a cache that expires after one day.Testing Guide
Delete
~/.azure/versionCheck.json, runaz version.Before this PR:
After this PR: