Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] az acr agentpool: Fix delete polling #30485

Merged
merged 4 commits into from
Dec 16, 2024
Merged

[ACR] az acr agentpool: Fix delete polling #30485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cafde21
revert polling change
Dec 6, 2024
414266d
Merge branch 'Azure:dev' into nguyenma/revertPolling
nguyenm2151 Dec 6, 2024
888db2b
Merge branch 'dev' into nguyenma/revertPolling
Dec 11, 2024
377d459
Merge branch 'nguyenma/revertPolling' of https://github.com/nguyenm21…
Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acr/agentpool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def acr_agentpool_delete(cmd,
try:
response = client.begin_delete(resource_group_name=resource_group_name,
registry_name=registry_name,
agent_pool_name=agent_pool_name).result()
agent_pool_name=agent_pool_name)

if no_wait:
logger.warning("Started to delete the agent pool '%s': %s", agent_pool_name, response.status())
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_agentpool_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from azure.cli.testsdk import ScenarioTest, StorageAccountPreparer, ResourceGroupPreparer, record_only

from azure.cli.testsdk import ScenarioTest, StorageAccountPreparer, ResourceGroupPreparer, record_only, live_only

class AcrAgentPoolCommandsTests(ScenarioTest):

@live_only()
@ResourceGroupPreparer()
def test_acr_agentpool(self, resource_group):
# Agentpool prerequisites for agentpool testing
Expand Down