{Misc} Remove Python 3.8 typing fallbacks #30473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
evelyn-ys,
jiasli and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution atombrella! We will review the pull request and get back to you soon. |
jiasli
reviewed
Dec 9, 2024
Comment on lines
-35
to
-38
| if sys.version_info < (3, 9): | ||
| from typing import Awaitable | ||
| else: | ||
| from collections.abc import Awaitable |
There was a problem hiding this comment.
@evelyn-ys, let's make sure the newer SDK no longer contains such code.
There was a problem hiding this comment.
The Python SDK supports Python versions until 6 months after official end of support from PSF (version support policy). Since 3.8 went EOL this October, we'll drop support in April 2025. At that point we can remove conditional imports like this one in the SDK.
jiasli
approved these changes
Dec 9, 2024
evelyn-ys
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.9 seems to be the minimum requirement.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.