Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VDOT during Session Host Configuration #698 #709

Closed
wants to merge 43 commits into from

Conversation

chbragg
Copy link
Contributor

@chbragg chbragg commented Nov 5, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixed VDOT doesn't run during Set-SessionHostConfiguration script #698
  2. Excludes Snipping Tool, Calculator, Notepad, and Windows Terminal from getting removed by VDOT.
  3. Changed Optimizations from 'All' to everything except for 'DiskCleanup' because 'DiskCleanup' sometimes causes a permissions error and the deployment will fail.

Breaking Changes

  1. Since VDOT has never run successfully previously, new runs of VDOT may cause changes to apps, services, and policies.

Testing Evidence

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre
Copy link
Collaborator

@chbragg thank you for your contribution, we have decided to remove VDOT functionality from the code given the variability of what customers could want to be part of the image.

@swathibhat1

@danycontre danycontre closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VDOT doesn't run during Set-SessionHostConfiguration script
2 participants