upgrade tsp to 0.63, liftr to 0.6 and fixed related testcase issues c…

…aused by the change (#1417)
Azure · Dec 18, 2024 · 50772a2 · 50772a2
1 parent 4dadee8
commit 50772a2
Show file tree

Hide file tree

Showing 55 changed files with 1,535 additions and 755 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/packages/typespec-powershell/package.json b/packages/typespec-powershell/package.json
@@ -30,8 +30,8 @@
     "xmlbuilder": "10.1.1"
   },
   "devDependencies": {
-    "@typespec/compiler": ">=0.61.0 <1.0.0",
-    "@typespec/openapi": ">=0.61.0 <1.0.0",
+    "@typespec/compiler": ">=0.49.0 <1.0.0",
+    "@typespec/openapi": ">=0.49.0 <1.0.0",
     "@testdeck/mocha": "0.3.3",
     "@types/js-yaml": "3.12.1",
     "@types/mocha": "5.2.5",
@@ -46,12 +46,12 @@
     "vitest": "1.2.1"
   },
   "peerDependencies": {
-    "@azure-tools/typespec-azure-core": ">=0.47.0 <1.0.0",
-    "@azure-tools/typespec-client-generator-core": ">=0.47.0 <1.0.0",
-    "@typespec/compiler": ">=0.61.0 <1.0.0",
-    "@typespec/http": ">=0.61.0 <1.0.0",
-    "@typespec/rest": ">=0.61.0 <1.0.0",
-    "@typespec/versioning": ">=0.61.0 <1.0.0"
+    "@azure-tools/typespec-azure-core": ">=0.49.0 <1.0.0",
+    "@azure-tools/typespec-client-generator-core": ">=0.49.0 <1.0.0",
+    "@typespec/compiler": ">=0.49.0 <1.0.0",
+    "@typespec/http": ">=0.49.0 <1.0.0",
+    "@typespec/rest": ">=0.49.0 <1.0.0",
+    "@typespec/versioning": ">=0.49.0 <1.0.0"
   },
   "scripts": {
     "build": "tsc",

diff --git a/...tests-emitter/AppComplianceAutomation.Management/target/generated/api/Models/Operation.cs b/...tests-emitter/AppComplianceAutomation.Management/target/generated/api/Models/Operation.cs
@@ -20,14 +20,14 @@ public partial class Operation :
         /// Extensible enum. Indicates the action type. "Internal" refers to actions that are for internal only APIs.
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Origin(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.PropertyOrigin.Owned)]
-        public string ActionType { get => this._actionType; set => this._actionType = value; }
+        public string ActionType { get => this._actionType; }
 
         /// <summary>Backing field for <see cref="Display" /> property.</summary>
         private Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationDisplay _display;
 
         /// <summary>Localized display information for this particular operation.</summary>
         [Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Origin(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.PropertyOrigin.Owned)]
-        internal Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.OperationDisplay()); }
+        internal Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.OperationDisplay()); set => this._display = value; }
 
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
@@ -64,6 +64,9 @@ public partial class Operation :
         [Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Origin(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.PropertyOrigin.Owned)]
         public bool? IsDataAction { get => this._isDataAction; }
 
+        /// <summary>Internal Acessors for ActionType</summary>
+        string Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationInternal.ActionType { get => this._actionType; set { {_actionType = value;} } }
+
         /// <summary>Internal Acessors for Display</summary>
         Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationDisplay Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.IOperationInternal.Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Models.OperationDisplay()); set { {_display = value;} } }
 
@@ -123,15 +126,15 @@ public partial interface IOperation :
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Info(
         Required = false,
-        ReadOnly = false,
+        ReadOnly = true,
         Read = true,
-        Create = true,
-        Update = true,
+        Create = false,
+        Update = false,
         Description = @"Extensible enum. Indicates the action type. ""Internal"" refers to actions that are for internal only APIs.",
         SerializedName = @"actionType",
         PossibleTypes = new [] { typeof(string) })]
         [global::Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.PSArgumentCompleterAttribute("Internal")]
-        string ActionType { get; set; }
+        string ActionType { get;  }
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
         /// </summary>

diff --git a/...-emitter/AppComplianceAutomation.Management/target/generated/api/Models/Operation.json.cs b/...-emitter/AppComplianceAutomation.Management/target/generated/api/Models/Operation.json.cs
@@ -104,10 +104,7 @@ public Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.J
             {
                 return container;
             }
-            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.SerializationMode.IncludeRead))
-            {
-                AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
-            }
+            AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
             if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.SerializationMode.IncludeRead))
             {
                 AddIf( null != (((object)this._name)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonString(this._name.ToString()) : null, "name" ,container.Add );
@@ -120,7 +117,10 @@ public Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.J
             {
                 AddIf( null != (((object)this._origin)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonString(this._origin.ToString()) : null, "origin" ,container.Add );
             }
-            AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.SerializationMode.IncludeRead))
+            {
+                AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.AppComplianceAutomation.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            }
             AfterToJson(ref container);
             return container;
         }

diff --git a/...pgrade/tests-emitter/Astronomer.Astro.Management/target/generated/api/Models/Operation.cs b/...pgrade/tests-emitter/Astronomer.Astro.Management/target/generated/api/Models/Operation.cs
@@ -20,14 +20,14 @@ public partial class Operation :
         /// Extensible enum. Indicates the action type. "Internal" refers to actions that are for internal only APIs.
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.Astro.Origin(Microsoft.Azure.PowerShell.Cmdlets.Astro.PropertyOrigin.Owned)]
-        public string ActionType { get => this._actionType; set => this._actionType = value; }
+        public string ActionType { get => this._actionType; }
 
         /// <summary>Backing field for <see cref="Display" /> property.</summary>
         private Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationDisplay _display;
 
         /// <summary>Localized display information for this particular operation.</summary>
         [Microsoft.Azure.PowerShell.Cmdlets.Astro.Origin(Microsoft.Azure.PowerShell.Cmdlets.Astro.PropertyOrigin.Owned)]
-        internal Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.OperationDisplay()); }
+        internal Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.OperationDisplay()); set => this._display = value; }
 
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
@@ -64,6 +64,9 @@ public partial class Operation :
         [Microsoft.Azure.PowerShell.Cmdlets.Astro.Origin(Microsoft.Azure.PowerShell.Cmdlets.Astro.PropertyOrigin.Owned)]
         public bool? IsDataAction { get => this._isDataAction; }
 
+        /// <summary>Internal Acessors for ActionType</summary>
+        string Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationInternal.ActionType { get => this._actionType; set { {_actionType = value;} } }
+
         /// <summary>Internal Acessors for Display</summary>
         Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationDisplay Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.IOperationInternal.Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.Astro.Models.OperationDisplay()); set { {_display = value;} } }
 
@@ -123,15 +126,15 @@ public partial interface IOperation :
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Info(
         Required = false,
-        ReadOnly = false,
+        ReadOnly = true,
         Read = true,
-        Create = true,
-        Update = true,
+        Create = false,
+        Update = false,
         Description = @"Extensible enum. Indicates the action type. ""Internal"" refers to actions that are for internal only APIs.",
         SerializedName = @"actionType",
         PossibleTypes = new [] { typeof(string) })]
         [global::Microsoft.Azure.PowerShell.Cmdlets.Astro.PSArgumentCompleterAttribute("Internal")]
-        string ActionType { get; set; }
+        string ActionType { get;  }
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
         /// </summary>

diff --git a/...e/tests-emitter/Astronomer.Astro.Management/target/generated/api/Models/Operation.json.cs b/...e/tests-emitter/Astronomer.Astro.Management/target/generated/api/Models/Operation.json.cs
@@ -102,10 +102,7 @@ public Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode ToJson(Mic
             {
                 return container;
             }
-            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.SerializationMode.IncludeRead))
-            {
-                AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
-            }
+            AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
             if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.SerializationMode.IncludeRead))
             {
                 AddIf( null != (((object)this._name)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonString(this._name.ToString()) : null, "name" ,container.Add );
@@ -118,7 +115,10 @@ public Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode ToJson(Mic
             {
                 AddIf( null != (((object)this._origin)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonString(this._origin.ToString()) : null, "origin" ,container.Add );
             }
-            AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.SerializationMode.IncludeRead))
+            {
+                AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.Astro.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            }
             AfterToJson(ref container);
             return container;
         }

diff --git a/tests-upgrade/tests-emitter/AzureFleet.Management/target/generated/api/Models/Operation.cs b/tests-upgrade/tests-emitter/AzureFleet.Management/target/generated/api/Models/Operation.cs
@@ -20,14 +20,14 @@ public partial class Operation :
         /// Extensible enum. Indicates the action type. "Internal" refers to actions that are for internal only APIs.
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Origin(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.PropertyOrigin.Owned)]
-        public string ActionType { get => this._actionType; set => this._actionType = value; }
+        public string ActionType { get => this._actionType; }
 
         /// <summary>Backing field for <see cref="Display" /> property.</summary>
         private Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationDisplay _display;
 
         /// <summary>Localized display information for this particular operation.</summary>
         [Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Origin(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.PropertyOrigin.Owned)]
-        internal Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.OperationDisplay()); }
+        internal Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationDisplay Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.OperationDisplay()); set => this._display = value; }
 
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
@@ -64,6 +64,9 @@ public partial class Operation :
         [Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Origin(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.PropertyOrigin.Owned)]
         public bool? IsDataAction { get => this._isDataAction; }
 
+        /// <summary>Internal Acessors for ActionType</summary>
+        string Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationInternal.ActionType { get => this._actionType; set { {_actionType = value;} } }
+
         /// <summary>Internal Acessors for Display</summary>
         Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationDisplay Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.IOperationInternal.Display { get => (this._display = this._display ?? new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Models.OperationDisplay()); set { {_display = value;} } }
 
@@ -123,15 +126,15 @@ public partial interface IOperation :
         /// </summary>
         [Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Info(
         Required = false,
-        ReadOnly = false,
+        ReadOnly = true,
         Read = true,
-        Create = true,
-        Update = true,
+        Create = false,
+        Update = false,
         Description = @"Extensible enum. Indicates the action type. ""Internal"" refers to actions that are for internal only APIs.",
         SerializedName = @"actionType",
         PossibleTypes = new [] { typeof(string) })]
         [global::Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.PSArgumentCompleterAttribute("Internal")]
-        string ActionType { get; set; }
+        string ActionType { get;  }
         /// <summary>
         /// The short, localized friendly description of the operation; suitable for tool tips and detailed views.
         /// </summary>

diff --git a/...upgrade/tests-emitter/AzureFleet.Management/target/generated/api/Models/Operation.json.cs b/...upgrade/tests-emitter/AzureFleet.Management/target/generated/api/Models/Operation.json.cs
@@ -104,10 +104,7 @@ public Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode ToJ
             {
                 return container;
             }
-            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.SerializationMode.IncludeRead))
-            {
-                AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
-            }
+            AddIf( null != this._display ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) this._display.ToJson(null,serializationMode) : null, "display" ,container.Add );
             if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.SerializationMode.IncludeRead))
             {
                 AddIf( null != (((object)this._name)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonString(this._name.ToString()) : null, "name" ,container.Add );
@@ -120,7 +117,10 @@ public Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode ToJ
             {
                 AddIf( null != (((object)this._origin)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonString(this._origin.ToString()) : null, "origin" ,container.Add );
             }
-            AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            if (serializationMode.HasFlag(Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.SerializationMode.IncludeRead))
+            {
+                AddIf( null != (((object)this._actionType)?.ToString()) ? (Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonNode) new Microsoft.Azure.PowerShell.Cmdlets.ComputeFleet.Runtime.Json.JsonString(this._actionType.ToString()) : null, "actionType" ,container.Add );
+            }
             AfterToJson(ref container);
             return container;
         }

diff --git a/tests-upgrade/tests-emitter/AzureFleet.Management/virtualMachineScaleSet.tsp b/tests-upgrade/tests-emitter/AzureFleet.Management/virtualMachineScaleSet.tsp
@@ -57,6 +57,6 @@ model VirtualMachineScaleSetListResult {
   value: Array<VirtualMachineScaleSet>;
 
   @doc("The link to the next page of items")
-  @Azure.Core.nextLink
+  @nextLink
   nextLink?: url;
 }