-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .devops #261
Add .devops #261
Conversation
I am not sure why the tests are failing but this change does not (in my estimation) have an effect on the tests. |
|
||
variables: | ||
- name: version | ||
value: "3.8.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 3.9.9? Or was there an issue with later versions? I think @kthatipally told me something once...
Extra side note, we should just add mvnw to the Windup build and not have to worry about this. I can pair with someone to do that quickly if that's desirable (it would also change need to use Maven@4 task).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If my suggestion here holds things up then let's not do my suggestion, but open up an issue for later on. Keen to get this merged and make forward progress (can also fix those tests separately as they are unrelated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is WIP. All suggestions are welcome 😄
I need to check this YAML into the repo since I cannot run ADO pipelines from a fork (and therefore cannot execute any test runs). I could point this to a different branch, but I do not have those permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I do see a mvnw checked into the repo already. Could we use that? Assumption is yes.
I will also update the Maven task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was provided with access to the repo recently. Once I verify that I can create a branch to develop on I will close this PR.
Apologies for the noise.
I was provided with the proper level permissions to perform dev work and thus will close this PR. I again apologize for the noise this created. I will take the feedback in this PR and will apply it in the final change request. |
This change proposes adding a
.devops
folder containing YAML file to execute builds and a suppressions file.Builds will be performed once per week which will also run the SDL tools against the codebase.