Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: agent container zone support #59

Merged
merged 6 commits into from
Nov 29, 2024
Merged

fix: agent container zone support #59

merged 6 commits into from
Nov 29, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 29, 2024 •
edited
Loading

Overview/Summary

This PR fixes an issue identified in some regions that don't have availability zone support.

This PR fixes/adds/changes/removes

  1. Bug: ACI deployments fails in some regions when Availability Zones is enabled ALZ-PowerShell-Module#187

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Nov 29, 2024
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Nov 29, 2024
@jaredfholgate jaredfholgate merged commit 158d8f0 into main Nov 29, 2024
31 checks passed
@jaredfholgate jaredfholgate deleted the fix-agent-container-zone-support branch November 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

@oZakari oZakari Awaiting requested review from oZakari

@jtracey93 jtracey93 Awaiting requested review from jtracey93

Assignees

@jaredfholgate jaredfholgate

Labels
PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredfholgate @matt-FFFFFF