feat: Fix malformed json from arch def template #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeguchi
force-pushed
the
feature-update-confidential-archetypes
branch
from
a2279c2 to
41f8beb
Compare
jaredfholgate
approved these changes
Nov 1, 2024
VeronicaSea
pushed a commit
to Azure/sovereign-landing-zone
that referenced
this pull request
Jan 10, 2025
<!-- Thank you for submitting a Pull Request. Please fill out the template below.--> # Overview/Summary Updates the assignment of the FSI archetypes, fixes issues in ## This PR fixes/adds/changes/removes 1. Updates archetype assignment of the confidential policies 2. Fixes gateway configuration variables ### Breaking Changes 1. Depends on Azure/accelerator-bootstrap-modules#57 or duplicate archetype assignment will occur. ## Testing Evidence  # Documentation Related wiki link or design document, if applicable. ---- #### AI description (iteration 1) #### PR Classification Code cleanup and enhancement of policy assignments for FSI. #### PR Summary This pull request updates the FSI archetypes by removing duplicate policy assignments and refining configurations. - `/internal/terraform/Azure-Landing-Zones-Library/platform/fsi/policy_assignments/sd_01_allowed_services.alz_policy_assignment.json`: Removed extensive lists of allowed SKUs and resource types, setting them to empty arrays. - `/internal/terraform/alz-terraform-accelerator/templates/microsoft_cloud_for_industry/microsoft_cloud_for_financial_services/variables.tf`: Added `gatewayType` and corrected `vpnType` in `express_route_gateway_config` and `vpn_gateway_config` objects. - `/internal/terraform/alz-terraform-accelerator/templates/microsoft_cloud_for_industry/modules/platform/variables.tf`: Similar updates as above, adding `gatewayType` and correcting `vpnType`. - `/internal/terraform/alz-terraform-accelerator/templates/microsoft_cloud_for_industry/microsoft_cloud_for_financial_services/templates/fsi.alz_architecture_definition.json.tftpl`: Updated archetypes to include `so_04_cmk` and `so_01_data_residency` in the root management group and removed them from confidential groups. Related work items: #30083854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
As part of this Pull Request I have
mainbranch