Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add roles for legacy telemetry provider #56

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: add roles for legacy telemetry provider #56

merged 1 commit into from
Oct 31, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Oct 31, 2024 •
edited
Loading

Overview/Summary

Add permissions required to read a deployment template for the legacy telemetry provider

This PR fixes/adds/changes/removes

  1. terraform plan identity is missing permission for subsequent runs ALZ-PowerShell-Module#241

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Oct 31, 2024
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Oct 31, 2024
matt-FFFFFF
matt-FFFFFF approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate merged commit 1d069c1 into main Oct 31, 2024
38 of 39 checks passed
@jaredfholgate jaredfholgate deleted the fix-permissions-for-telemetry branch October 31, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

Assignees

@jaredfholgate jaredfholgate

Labels
PR: Safe to test 🧪 Enables running of End to End Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredfholgate @matt-FFFFFF