Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add additional permissions for bicep deployment permissions #39

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Sep 24, 2024

Overview/Summary

Fixes #188

This PR fixes/adds/changes/removes

  1. Adds "Microsoft.Insights/diagnosticSettings/write" to mgmt group contributor
  2. Adds "Microsoft.Authorization/policyAssignments/write" to mgmt group contributor

Breaking Changes

1.None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@oZakari oZakari added the Type: Bug 🪲 Something isn't working label Sep 24, 2024
@oZakari oZakari changed the title bug: Add diagnostic settings write permissions fix: Add diagnostic settings write permissions Sep 24, 2024
@oZakari oZakari changed the title fix: Add diagnostic settings write permissions fix: Add additional permissions for bicep deployment permissions Sep 24, 2024
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit 3422444 into Azure:main Sep 24, 2024
8 checks passed
@oZakari oZakari deleted the general-bug-fixes branch September 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🪲 Something isn't working
Projects
None yet
2 participants