Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PSRule] Fix Rule Azure.VM.AMA #3938

Closed
wants to merge 11 commits into from
Closed

[PSRule] Fix Rule Azure.VM.AMA #3938

wants to merge 11 commits into from

Conversation

fabmas
Copy link
Member

@fabmas fabmas commented Sep 7, 2023

Description

Fix Rule Azure.VM.AMA
Close Azure/bicep-registry-modules#2377

Pipeline references

Pipeline
Compute - VirtualMachines

Type of Change

  • [ X ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • [ x ] I'm sure there are no other open Pull Requests for the same update/change
  • [ x ] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation (readme)
  • [ x ] I did format my code

@fabmas fabmas added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Sep 7, 2023
@fabmas fabmas self-assigned this Sep 7, 2023
@fabmas fabmas requested a review from a team as a code owner September 7, 2023 12:55
@fabmas fabmas enabled auto-merge (squash) September 7, 2023 12:55
eriqua
eriqua reviewed Sep 7, 2023
View reviewed changes
modules/compute/virtual-machine/main.bicep
@@ -567,19 +567,21 @@ resource vm_logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2021
scope: az.resourceGroup(split(monitoringWorkspaceId, '/')[2], split(monitoringWorkspaceId, '/')[4])
}

module vm_microsoftMonitoringAgentExtension 'extension/main.bicep' = if (extensionMonitoringAgentConfig.enabled) {
name: '${uniqueString(deployment().name, location)}-VM-MicrosoftMonitoringAgent'
module vm_azureMonitorAgentExtension 'extension/main.bicep' = if (extensionMonitoringAgentConfig.enabled) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per similar discussion for VMSS (ref #3918 (comment)) we won't be including this change into release 0.11 to avoid an additional breaking change. We should discuss and decide on if keeping both AMA and MMA extensions or if discontinuing support for MMA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the other, I believe this can and should be merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @eriqua :D By now already have quite some conflicts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus I believe @rahalan is already working on the migration into AVM. So it's high time this is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @eriqua

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looping in @rahalan, AVM VM and VMSS module owner, to finalize the decision on if keeping the legacy MMA support or just remove it as part of migration to AVM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has to be merged into AVM module as soon as its PR is merged

@AlexanderSehr AlexanderSehr requested a review from eriqua November 19, 2023 10:33
@AlexanderSehr AlexanderSehr mentioned this pull request Jan 10, 2024
Merged
@AlexanderSehr
Copy link
Contributor

Closing PR as merged in via PR Azure/bicep-registry-modules#717 and expanded on in PR Azure/bicep-registry-modules#784. Thanks @fabmas :)

auto-merge was automatically disabled January 10, 2024 13:00

Pull request was closed

AlexanderSehr added a commit to Azure/bicep-registry-modules that referenced this pull request Jan 15, 2024
@AlexanderSehr @eriqua
feat: Restored features of CARML AMA PR (#784)
fa5b073 
## Description

- Retored the functionality introduced by PR
Azure/ResourceModules#3938
- Updated Set-AVMModule utility to be able to handle modules that don't
use plane test names like `max` but instead e.g., `<prefix>.max`
- Small update to docs and regeneration of files
- Shifted deployment location as encountering capacity issues in
WestEurope
- Added a warning supression for Network/Connection that was added for
the same reason

| Pipeline |
| - |
|
[![avm.res.compute.virtual-machine](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml/badge.svg?branch=users%2Falsehr%2FvmUpdate20240110&event=workflow_dispatch)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.compute.virtual-machine.yml)
|

---------

Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua Awaiting requested review from eriqua

Assignees

@fabmas fabmas

Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
Azure Verified Modules (AVM) - Module...
Development

Successfully merging this pull request may close these issues.

[PSRule] Fix Rule Azure.VM.AMA
3 participants
@fabmas @AlexanderSehr @eriqua