Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Render copied tooltip properly #6463

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Jan 24, 2025

Type of Change

  • Bug fix

Fixes - #6076

Current Behavior

Tooltip wasn't rendering properly in vscode as well as in portal. The tooltip was getting rendered at the top left corner of the screen instead of the target element.

New Behavior

Tooltip is now rendering in a location related to the target element. In both cases when using the contextual menu and when using Ctrl+C

Impact of Change

Cosmetic change non functionality affected

Test Plan

Unit tests - Added to the CopyTooltip component
Screenshot 2025-01-24 at 11 45 58 AM
E2E - Updated e2e tests

Screenshots or Videos (if applicable)

New behavior VSCode

Screen.Recording.2025-01-23.at.4.29.47.PM.mov

New behavior standalone

Screen.Recording.2025-01-23.at.4.32.20.PM.mov

@ccastrotrejo ccastrotrejo added the Cosmetic Purely visual bug label Jan 24, 2025
@ccastrotrejo ccastrotrejo changed the title Update component to render properly fix(designer): Render copied tooltip properly Jan 24, 2025
@ccastrotrejo ccastrotrejo marked this pull request as ready for review January 24, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetic Purely visual bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants