fix: retire gpu dedicated aks image #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
added 2 commits
January 10, 2025 13:34
pkg/agent/datamodel/sig_config.go
Outdated
| @@ -378,6 +378,12 @@ const ( | |||
| // of support and image builds have stopped. | |||
| FrozenCBLMarinerV1SIGImageVersionForDeprecation string = "202308.28.0" | |||
|
|
|||
| // DO NOT MODIFY: 1804GPUContainerd Gen1 & Gen2 pinned to the last image build as | |||
| // GPU Dedicated preview image is being deprecated and image builds have stopped. | |||
| Frozen1804Gen1GPUDedicatedVHDContainerdSIGIMageVersionForDeprecation string = "202412.29.0" | |||
There was a problem hiding this comment.
nit: Frozen1804GPUContainerdSIGImageVersionForDeprecation
There was a problem hiding this comment.
@cameronmeissner fixed!
There was a problem hiding this comment.
I would also do
Frozen1804Gen2GPUDedicatedVHDContainerdSIGIMageVersionForDeprecation -> Frozen1804Gen2GPUContainerdSIGImageVersionForDeprecation
There was a problem hiding this comment.
Thanks. Changed it. Not sure why I made those different haha.
E2E is failing for PR gate for all PRs that I see, so Im going to wait until all the other checks pass and then bypass merge for the release Monday.
zachary-bailey
added a commit
that referenced
this pull request
Jan 11, 2025
Co-authored-by: Zachary Bailey <[email protected]> Co-authored-by: Zachary Bailey <[email protected]>
3 tasks
zachary-bailey
added a commit
that referenced
this pull request
Jan 11, 2025
Co-authored-by: Zachary Bailey <[email protected]> Co-authored-by: Zachary Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
This PR deprecates the 1804gpucontainerd images.
Requirements: