-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AKS GPU consumption to use separate images per GPU driver type #5133
Merged
ganeshkumarashok
merged 8 commits into
master
from
aganeshkumar/refactor_aks_gpu_format
Oct 22, 2024
Merged
Refactor AKS GPU consumption to use separate images per GPU driver type #5133
ganeshkumarashok
merged 8 commits into
master
from
aganeshkumar/refactor_aks_gpu_format
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshkumarashok
requested review from
juan-lee,
cameronmeissner,
UtheMan,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
October 21, 2024 21:58
ganeshkumarashok
changed the title
refactor to use separate images
Refactor AKS GPU consumption to use separate images per GPU driver type
Oct 21, 2024
Devinwong
reviewed
Oct 21, 2024
…r/refactor_aks_gpu_format
jason1028kr
reviewed
Oct 22, 2024
jason1028kr
approved these changes
Oct 22, 2024
…r/refactor_aks_gpu_format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / why we need it:
We are now producing two separate images for CUDA and GRID, in the aks-gpu repo. This refactor, allows us to consume the two aks-gpu images separately. This will eventually help with automation with Renovate bot, as previously having one image with tags to separate
cuda
andgrid
wouldn't allow renovate to differentiate between them.Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: