Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VHD release automation to go #5125

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

cameronmeissner
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

refactors automation of SIG release creation to go from bash - this ends up fixing a bug we've seen recently where curling to the ADO REST APIs fails due to a protocol which ends up causing automated release creation to fail

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Copy link
Collaborator

@Devinwong Devinwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Didn't know the fix needs to put so much effort 🥲

@cameronmeissner cameronmeissner merged commit ed7380a into master Oct 21, 2024
15 checks passed
@cameronmeissner cameronmeissner deleted the cameissner/releaser-binary branch October 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants