Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: workflows and make targets #5118

Merged
merged 11 commits into from
Oct 21, 2024
Merged

Conversation

cameronmeissner
Copy link
Collaborator

@cameronmeissner cameronmeissner commented Oct 18, 2024

What type of PR is this?

What this PR does / why we need it:

This PR aims to accomplish the following:

  • cleanup the monolithic generate make target, which has become overloaded with many different sub-targets and often leaves devs confused when it fails.
  • add/revive new + old github workflows such that all tests previously ran by generate have their own dedicated workflows to make debugging much easier and less confusing
  • rename workflows to make their respective intentions much more clear, "check-tests/coverage/generated" was quite confusing
  • remove the check-generated workflow, which previously ran make generate and asserted that no diff was produced. Failure to generate testdata will now be checked by the go unit test workflow, which will fail if testdata needs to be regenerated and it hasn't

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@cameronmeissner cameronmeissner changed the title refactor: add shellspec workflow, remove shellspec from generate target refactor: workflows and make targets Oct 18, 2024
@cameronmeissner cameronmeissner merged commit fcceab3 into master Oct 21, 2024
13 checks passed
@cameronmeissner cameronmeissner deleted the cameissner/shellspec branch October 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants