-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: configure kubelet serving certificate rotation label at runtime #5115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR.
is it safe to remove the equivalent logic from |
we need to keep it in there for now since we can't release everything at once for windows (they need to create a new script package before we can start calling new functions from within the primary CSE scripts) I'll follow-up and remove that logic once windows has everything released |
…eissner/kscr-label-scripts
…eissner/kscr-label-scripts
What type of PR is this?
What this PR does / why we need it:
this PR moves the logic which adds the special
kubernetes.azure.com/kubelet-serving-ca=cluster
label out of agentbaker and directly into provisioning scripts - this is primarily to ensure that we preserve this functionality when using scriptless, and there is no agentbakersvcWhich issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: