Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configure kubelet serving certificate rotation label at runtime #5115

Merged
merged 22 commits into from
Oct 21, 2024

Conversation

cameronmeissner
Copy link
Collaborator

@cameronmeissner cameronmeissner commented Oct 18, 2024

What type of PR is this?

What this PR does / why we need it:

this PR moves the logic which adds the special kubernetes.azure.com/kubelet-serving-ca=cluster label out of agentbaker and directly into provisioning scripts - this is primarily to ensure that we preserve this functionality when using scriptless, and there is no agentbakersvc

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@cameronmeissner cameronmeissner changed the title Cameissner/kscr label scripts refactor: configure kubelet serving certificate rotation at runtime Oct 18, 2024
@cameronmeissner cameronmeissner changed the title refactor: configure kubelet serving certificate rotation at runtime refactor: configure kubelet serving certificate rotation label at runtime Oct 18, 2024
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@lilypan26
Copy link
Contributor

is it safe to remove the equivalent logic from baker.go files? Or do we still need it there as well

@cameronmeissner
Copy link
Collaborator Author

is it safe to remove the equivalent logic from baker.go files? Or do we still need it there as well

we need to keep it in there for now since we can't release everything at once for windows (they need to create a new script package before we can start calling new functions from within the primary CSE scripts)

I'll follow-up and remove that logic once windows has everything released

@cameronmeissner cameronmeissner merged commit fdc208b into master Oct 21, 2024
25 of 31 checks passed
@cameronmeissner cameronmeissner deleted the cameissner/kscr-label-scripts branch October 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants