chore: move shared pcs functionality to internal library in solidity and small refactorings in sumcheck #11230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maramihali
commented
Jan 15, 2025
•
maramihali
commented
- functionality that is shared in PCS between the ZK and non-ZK contract has been moved to a separate internal library.
- simplified ZK sumcheck and pcs logic
maramihali
requested review from
jeanmon,
IlyasRidhuan and
fcarreiro
as code owners
jeanmon
reviewed
Jan 15, 2025
There was a problem hiding this comment.
@maramihali Would you mind updating the template files ?:
- bb-pilcom/bb-pil-backend/templates/recursive_verifier.cpp.hbs
- bb-pilcom/bb-pil-backend/templates/verifier.cpp.hbs
Otherwise, let us know if AVM team should do that.
maramihali
changed the title
|
@jeanmon on it :) |
Maddiaa0
reviewed
Jan 15, 2025
iakovenkos
reviewed
Jan 15, 2025
barretenberg/cpp/src/barretenberg/commitment_schemes/gemini/gemini_impl.hpp
Show resolved
Hide resolved
iakovenkos
reviewed
Jan 15, 2025
iakovenkos
reviewed
Jan 15, 2025
jeanmon
reviewed
Jan 15, 2025
iakovenkos
reviewed
Jan 15, 2025
| // For ZK Flavors: the sum of the Libra constant term and Libra univariates evaluated at Sumcheck challenges, | ||
| // otherwise remains the default value 0 | ||
| FF claimed_libra_evaluation = 0; | ||
| std::optional<bool> verified = false; // Optional b/c this struct is shared by the Prover/Verifier |
There was a problem hiding this comment.
do we need to keep it std::optional? switching to just bool would reduce noise in our verifiers
There was a problem hiding this comment.
I think the idea of the std::optional is to make it explicit this value is not present for the prover
jeanmon
reviewed
Jan 15, 2025
iakovenkos
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.