chore: pcs tests refactor #11188
chore: pcs tests refactor #11188
Conversation
| @@ -12,24 +13,27 @@ template <class Curve> class GeminiTest : public CommitmentTest<Curve> { | |||
| using Commitment = typename Curve::AffineElement; | |||
There was a problem hiding this comment.
cleaned up witness and instance generation, also switched to creating a ck of the size controlled by the test suite inputs
| #include "./mock_transcript.hpp" | ||
| #include "barretenberg/commitment_schemes/commitment_key.test.hpp" | ||
| #include "barretenberg/commitment_schemes/shplonk/shplemini.hpp" | ||
| #include "barretenberg/commitment_schemes/utils/instance_witness_generator.hpp" | ||
| using namespace bb; | ||
|
|
There was a problem hiding this comment.
removed manual witness/instance generation in integration tests/ some clean-up in unit tests, trying to make the test suites more uniform
| unshifted_polynomials[idx] = Polynomial::random(n); | ||
| unshifted_commitments.push_back(ck->commit(unshifted_polynomials[idx])); | ||
| unshifted_evals.push_back(unshifted_polynomials[idx].evaluate_mle(mle_opening_point)); | ||
| if (!unshifted_polynomials.empty()) { |
There was a problem hiding this comment.
for edge case testing - needed to test the situation when Gemini opens only shifts
| size_t idx = num_unshifted; | ||
|
|
||
| // Add unshifted evaluations of shiftable polynomials | ||
| if (!unshifted_polynomials.empty()) { |
There was a problem hiding this comment.
as above - to support 0 unshifted polynomials as input
…c-packages into si/pcs-tests-clean-up
barretenberg/cpp/src/barretenberg/commitment_schemes/gemini/gemini.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/commitment_schemes/gemini/gemini.test.cpp
Outdated
Show resolved
Hide resolved
| @@ -19,12 +19,12 @@ template <typename Curve> struct InstanceWitnessGenerator { | |||
| using Polynomial = bb::Polynomial<Fr>; | |||
There was a problem hiding this comment.
I found the name of this class to be a little bit confusing. Maybe "instance" is a term that's used to refer to witness commitments in PG or something? Even if so, we don't use that term elsewhere in the code AFAIK. Also, I think its always ideal to have Test or Mock in the name of a class like this since its purely a test class.
There was a problem hiding this comment.
then --> MockWitnessGenerator
I wanted to emphasize that we also produce the evaluations and commitments in this class, and they define an instance for the PCS opening protocol. but I guess it's a bit redundant in the context of the PCS test suites
Cleaned up Gemini, IPA, and KZG tests