Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consensus layer in spartan #11105

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat: consensus layer in spartan #11105

wants to merge 22 commits into from

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jan 8, 2025

fixes: #10055

@Maddiaa0 Maddiaa0 force-pushed the md/10054-blob-sink-in-process branch from 27c75cd to 4ab57e1 Compare January 8, 2025 14:27
Copy link
Member Author

Maddiaa0 commented Jan 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Maddiaa0 Maddiaa0 force-pushed the md/10054-blob-sink-in-process branch from 4ab57e1 to 49b37dd Compare January 8, 2025 19:26
@Maddiaa0 Maddiaa0 added the network-all Run this CI job. label Jan 8, 2025
@Maddiaa0 Maddiaa0 marked this pull request as ready for review January 8, 2025 20:31
@@ -0,0 +1,3 @@
# Used with the eth2-testnet-generator
Copy link
Member Author

@Maddiaa0 Maddiaa0 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need to worry about this being public, it just controls our eth not aztec validators

@@ -400,6 +400,8 @@ export const deployL1Contracts = async (
account.address.toString(),
rollupConfigArgs,
];
await deployer.waitForDeployments();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not deploy if i did not add this - took a while to debug

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.

@Maddiaa0 Maddiaa0 requested a review from just-mitch January 8, 2025 20:53
@@ -61,20 +61,6 @@ spec:
- name: config
mountPath: /shared/config
{{- if .Values.bootNode.deployContracts }}
- name: deploy-create2-deployer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced by predeploying the account in genesis.json

requests:
memory: "2Gi"
cpu: "200m"
blockTime: 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

{{- end }}
initContainers:
- name: create-genesis
image: maddiaa/eth2-val-tools:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant bootstrap without it on any branches so i thought id leave it in, i assume other people have this issue

Copy link
Collaborator

@just-mitch just-mitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Really cool to see this.

Base automatically changed from md/10054-blob-sink-in-process to master January 9, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network-all Run this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(blobs): add consensus layer client to spartan
2 participants