-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consensus layer in spartan #11105
base: master
Are you sure you want to change the base?
Conversation
27c75cd
to
4ab57e1
Compare
0138c8a
to
63f96a1
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4ab57e1
to
49b37dd
Compare
80b72b8
to
385ea7f
Compare
c00110f
to
01271d4
Compare
@@ -0,0 +1,3 @@ | |||
# Used with the eth2-testnet-generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need to worry about this being public, it just controls our eth not aztec validators
@@ -400,6 +400,8 @@ export const deployL1Contracts = async ( | |||
account.address.toString(), | |||
rollupConfigArgs, | |||
]; | |||
await deployer.waitForDeployments(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not deploy if i did not add this - took a while to debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch.
8f766b6
to
10dfd4e
Compare
@@ -61,20 +61,6 @@ spec: | |||
- name: config | |||
mountPath: /shared/config | |||
{{- if .Values.bootNode.deployContracts }} | |||
- name: deploy-create2-deployer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced by predeploying the account in genesis.json
requests: | ||
memory: "2Gi" | ||
cpu: "200m" | ||
blockTime: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
{{- end }} | ||
initContainers: | ||
- name: create-genesis | ||
image: maddiaa/eth2-val-tools:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.yarn/install-state.gz
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i cant bootstrap without it on any branches so i thought id leave it in, i assume other people have this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Really cool to see this.
0dd5c48
to
861620d
Compare
fixes: #10055