Fix GIF freezing issues. #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last thing, the file is currently using tabs as spacers. Please convert the entire file to spaces or update your changes to use tabs, thanks 😃 |
|
Great catch! Thank you, should be changed back to tabs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the option to disable GIF animation, sometimes GIFs still don't freeze on page load (an example.) Strangely, I've had no problems when the GIFs are further down in the page, like Crusader's post here. Edit: my posts per page setting is 5, for reference.
With some of the changes, there may be some dead code left over, but I'm not sure if all images get wrapped in
<a>tags due to the exception inAwfulPost.java:507checking if an image has anolinkattribute. I couldn't find an example of an image with that attribute but I can't say for sure.