Scan for previous area value across a range of addresses #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious-Area-scan
for more information, see https://pre-commit.ci
…ious-Area-scan
…ools into Previous-Area-scan
Avasam
commented
Jul 16, 2024
Avasam
commented
Jul 16, 2024
| @@ -157,6 +151,7 @@ class Choice(IntEnum): | |||
|
|
|||
|
|
|||
| def highjack_transition_rando(): | |||
| return None | |||
There was a problem hiding this comment.
Reminder to revert this line before merging
Suggested change
| return None |
Avasam
commented
Jul 16, 2024
|
Newfound issue: since the correct ID can appear in multiple places, finding the first address is fine to read from, but is not necessarily the address to write to ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea for a potential hacky workaround to make "previous area id" a lot more stable across death and save loads. First tests are promising.