Adjust/avoid AOT compatibility warnings/errors #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styled behavior
…d triggers *should not* raise errors all the time
…angePropertyAction, DataTriggerBehavior and EventTriggerBehavior RequiresUnreferencedCode
maxkatz6
force-pushed
the
aot-compatibility
branch
from
51bd37e
to
c314bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR doesn't fix most of real AOT compatibility issues. But it removes some low-hanging fruits (like FromEventPattern usage).
PR can be reviewer commit-by-commit. No behavioral changes should have been introduced.
The biggest difference that needs to be highlighted is removal of
RequiresUnreferencedCodefrom Behavior.OnAttached and Trigger.OnAttached, which was producing AOT warnings/errors always for any behaviors SDK usage.After this PR,
RequiresUnreferencedCodeis used only on types that actually require unreferenced code. For example, DraggableDemo and DragAndDropDemo now compliable with zero relevant AOT warnings/errors.BehaviorsTestApplication understandably heavily relies on reflection (as it needs to show-case all behavior features), so it requires TrimmerRootAssembly hints.
Some of classes, like
ChangeAvaloniaPropertyActioncould get some help from XAML compiler, which could inject DynamicDependency trimmer attributes (which wouldn't resolve warnings). Or these could be made generic classes with less reflection (XAML compiler works well with generics in recent releases).