Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the user modifies the ColumnList ensure the TreeDataColumnHeader.ColumnIndex is kept in sync #311

Conversation

danwalmsley
Copy link
Member

Currently changing the column order breaks the sorting, because the columnheaders ColumnIndex is still pointing to the old arrangement.

  • Add a failing unit test.
  • Fix it by updating the ColumnIndex.

Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grokys grokys enabled auto-merge October 14, 2024 10:58
@grokys grokys merged commit da3f3ab into master Oct 14, 2024
2 of 3 checks passed
@grokys grokys deleted the fixes/update-column-header-column-index-when-changing-column-orders branch October 14, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants