Propagate the isExpanded value for all children in the hierarchy
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously expanding many nodes was expensive as the flattened list was being recalculated with each expansion. Add a recursive version which recalculates the flattened list at the end.
Previously reassigning hierarchical items was expensive as the flattened list was being recalculated with each row disposal. Ignore collection changes while the rows are being disposed and recalculate the flattened rows at the end.
Failing when sorting enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a filter calling the
ExpandRecursive()API, it's useful to have theisExpandedfilter value propagated to all nodes in the hierarchy, not just those below an expanded one.Previously, the
isExpandedfilter was only applied to nodes that were below a expanded one, leaving out nodes that weren't. This PR ensures that theisExpandedfilter now propagates to all nodes within the hierarchy.Performance is still good.