Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added group_by property #2007

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

added group_by property #2007

wants to merge 2 commits into from

Conversation

eleensmathew
Copy link

@eleensmathew eleensmathew commented Oct 10, 2024 •
edited
Loading

I made some changes to add group_by property. Please check and let me know where I'm going wrong? All kinds of pointers are appreciated. Fixes #169

@jrobinAV
Copy link
Member

Can you create unit tests of the new method get_grouped_scenario_list(entities, group_by)?
Unit tests help to:

  • make the PR easy to review
  • improve the readability and maintainability of the code
  • document how a method should be used
  • avoid future bugs or regressions

Thank you.

FredLL-Avaiga
FredLL-Avaiga requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finished yet :-)

taipy/gui_core/_context.py
def get_scenarios(
self,
scenarios: t.Optional[t.List[t.Union[Cycle, Scenario]]],
filters: t.Optional[t.List[t.Dict[str, t.Any]]],
sorts: t.Optional[t.List[t.Dict[str, t.Any]]],
group_by: t.Optional[str],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you specify that parameter ?
I think you need to add it as an external property in _GuiCoreLib.py

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for pointing that out. Will make the changes.

@jrobinAV jrobinAV added 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed hacktoberfest hacktoberfest issues hacktoberfest - 100💎 Issues rewarded by 100 points Core Related to Taipy Core 📈 Improvement Improvement of a feature. 📝Release Notes Impacts the Release Notes labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredLL-Avaiga FredLL-Avaiga FredLL-Avaiga requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI hacktoberfest - 100💎 Issues rewarded by 100 points hacktoberfest hacktoberfest issues 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scenario Selector - Group scenarios by year/month/week/day
3 participants
@eleensmathew @jrobinAV @FredLL-Avaiga