Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing login when Authorize form is non-English #108

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

akirk
Copy link
Member

@akirk akirk commented Dec 7, 2023

Fixes WordPress/matrix#6. Thanks @javiercasares for flagging and helping debug!

@akirk akirk requested a review from ashfame December 7, 2023 18:37
@akirk
Copy link
Member Author

akirk commented Dec 7, 2023

@ashfame I wonder why the response was completely empty, though. Do you recall what $response->send() is supposed to do here? Should we just echo an error message?

@ashfame
Copy link
Member

ashfame commented Dec 8, 2023

@akirk I checked, $response->send() simply uses the parameters set on $response to prepare the JSON output. In this case, neither there was any data nor any errors set on the object, hence was just a white screen. Now, I have set a 403 error if authorization on user consent fails, in addition to your fix.

Gonna get this deployed now.

Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Thanks for fixing!

@ashfame ashfame merged commit c49ec95 into main Dec 8, 2023
1 check passed
@ashfame ashfame deleted the fix-failing-login-non-en branch December 8, 2023 08:51
@ashfame ashfame mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot complete OIDC flow due to error
2 participants