-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Plugin Management: Return a redux action for update plugin #98896
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
'updating', | ||
( siteId: number, plugin: Plugin ) => { | ||
handleUpdatePlugins( [ plugin ], updatePluginAction, [] ); | ||
removePluginStatuses(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action does not seem to be required, removing it does not seem to break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~18 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working so quickly on this.
Looks good and works well.
Resolves https://github.com/Automattic/dotcom-forge/issues/10335
Proposed Changes
updatePlugins
instead of executing it as it is dispatchedWhy are these changes being made?
Testing Instructions
/plugins/manage/sites
Pending update
filterUpdate to version xxx
buttonPre-merge Checklist