Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Plugin Management: Return a redux action for update plugin #98896

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Jan 24, 2025

Resolves https://github.com/Automattic/dotcom-forge/issues/10335

Proposed Changes

  • Return the redux action for updatePlugins instead of executing it as it is dispatched

Why are these changes being made?

  • To fix the bug

Testing Instructions

  • Navigate to /plugins/manage/sites
  • Make sure you have one plugin installed that needs to be updated, you can take a previous version from WordPress.org/plugins
  • Click on the Pending update filter
  • Click on the Update to version xxx button
  • Ensure the plugin is updated
  • For another plugin, select it, to navigate to the sites view
  • Update the plugin clicking on the action in the site
  • Ensure the plugin is updated

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

'updating',
( siteId: number, plugin: Plugin ) => {
handleUpdatePlugins( [ plugin ], updatePluginAction, [] );
removePluginStatuses();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action does not seem to be required, removing it does not seem to break anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the intention was to remove the status of the previous action before dispatching a new one

CleanShot 2025-01-24 at 19 42 57

I think I like all the statuses displayed though as if someone clicks "Update" to multiple plugins they will end up with only the status of the last plugin clicked.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~18 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                                -38 B  (-0.0%)      -18 B  (-0.0%)
jetpack-cloud-plugin-management        -38 B  (-0.0%)      -18 B  (-0.0%)
a8c-for-agencies-plugins               -38 B  (-0.0%)      -18 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/bulk-plugin-management-update on your sandbox.

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working so quickly on this.
Looks good and works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants