Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Add notice for most recent open conversation #98884

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jan 24, 2025

Fixes: https://github.com/Automattic/dotcom-forge/issues/10298
Related to #98814

Proposed Changes

I need to merge #98814 first then reuse new hook.

  • Adds a notice to the odie client that will help navigate to that most recent open conversation

Why are these changes being made?

Testing Instructions

  • Checkout branch or use live link
  • Open the Help Center and start a conversation with AI (click start new conversation from the ellipsis menu , if you have an existing support conversation open)
  • Verify the notice appears at the bottom of the chat.
  • Verify the View conversation button navigates to the most recent open conversation.
  • Verify the x button hides the notice.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@agrullon95 agrullon95 added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Jan 24, 2025
@agrullon95 agrullon95 requested review from fditrapani and a team January 24, 2025 10:58
@agrullon95 agrullon95 self-assigned this Jan 24, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 24, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 24, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~202 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper       +771 B  (+0.1%)     +202 B  (+0.1%)
async-load-automattic-help-center               +771 B  (+0.1%)     +202 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95 agrullon95 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 24, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/hc-add-open-most-recent-convo-chat-notice on your sandbox.

@a8ci18n
Copy link

a8ci18n commented Jan 24, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17207670

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @agrullon95, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • You have another open conversation already started.
  • View conversation

Thank you in advance!

@fditrapani
Copy link
Contributor

The looks great and the flow works well. The View conversation link doesn't seem to be working at the moment though. Is that the hook you're referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants