Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: garbled icon in dashicons.css #98878

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: garbled icon in dashicons.css #98878

wants to merge 1 commit into from

Conversation

zaerl
Copy link
Contributor

@zaerl zaerl commented Jan 24, 2025

Related to https://github.com/Automattic/dotcom-forge/issues/8405
See: pMz3w-lpD-p2#comment-124426 for explanation

Proposed Changes

  • Replace dashicons.css with the core minified font CSS

Why are these changes being made?

See P2 discussion for details.

Testing Instructions

It's difficult to reproduce the source issue. But open multiple Calypso pages like /me, /posts, etc., and be sure all the icons seen are the same found on production.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@zaerl zaerl self-assigned this Jan 24, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/garbled-dashicon on your sandbox.

@zaerl zaerl added Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Bug When a feature is broken and / or not performing as intended labels Jan 24, 2025
@zaerl zaerl requested a review from davemart-in January 24, 2025 08:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
@zaerl zaerl requested a review from escapemanuele January 24, 2025 08:45
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants