-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribers: add plan filtering and sorting #98838
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~22 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~363 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~134 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Just merged the API update. This should be good to test now 👍👍 |
const isDataView = isEnabled( 'subscribers-dataviews' ); | ||
const [ perPage, setPerPage ] = useState( DEFAULT_PER_PAGE ); | ||
const [ sortOrder, setSortOrder ] = useState< 'asc' | 'desc' >(); | ||
const [ dataViewSortTerm, setDataViewSortTerm ] = useState< SubscribersSortBy >( | ||
SubscribersSortBy.DateSubscribed | ||
); | ||
const [ dataViewFilterOption, setDataViewFilterOption ] = useState< SubscribersFilterBy >( | ||
hasManySubscribers ? SubscribersFilterBy.WPCOM : SubscribersFilterBy.All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arcangelini Does this initially filter out email subscribers for sites with many subscribers, and then add the filtering option to Dataviews?
Related to #
Proposed Changes
paid
andfree
to filter options for query and use state instead of query args to store valueWhy are these changes being made?
This allows us to filter in the dataview component by plan and sort as well. This is only available if the user has subscribers otherwise subscriptions is not filter/sort-able.
This also need the API update to accommodate this request. 170845-ghe-Automattic/wpcom [ MERGED ] ✅
Testing Instructions
/subscribers/[ YOUR_SITE ]?flags=subscribers-dataviews
/subscribers/[ YOUR_SITE ]