A4A: Enable Jetpack Monitor paid tier by cleaning up feature flag logic

[vitozev]

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1697

Proposed Changes

Enable Jetpack Monitor paid tier visibility for Automattic for Agencies by removing legacy feature flag logic. The feature is now fully launched, making the development flag unnecessary.

Why are these changes being made?

Testing Instructions

• Create a new site and connect Jetpack
• Purchase Jetpack Monitor and assign it to your site
• Enable monitor from the dashboard
• Verify you see the paid features (such as "1-minute monitoring interval" or notifying email addresses) when you configure the notifications
• Verify no regression was introduced by this PR on Jetpack Manage

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130817

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130817&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-130817&env=a8c-for-agencies

[vitozev]

I removed this for now because the link didn't work and also, it's a bit too aggressive to have that many upgrade nudges.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/jetpack-manage-paid-monitor-feature-flag on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~164 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
jetpack-cloud-agency-sites-v2       -722 B  (-0.0%)     -164 B  (-0.0%)
a8c-for-agencies-sites              -541 B  (-0.0%)     -124 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.