Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename theme mods option #96

Closed
wants to merge 1 commit into from
Closed

rename theme mods option #96

wants to merge 1 commit into from

Conversation

rtio
Copy link
Member

@rtio rtio commented Jan 3, 2025

Summary

do a little rename

Testing steps

  • code review

Reviewing tips

🧁 Request a review to team CupcakeLabs to assign a random team member.

🔄 Feel free to ping the team name again to "re-roll" or add another team member.

🚀 For now there is no requirement on getting review approvals before merging.

@rtio rtio requested a review from aaronjbaptiste January 3, 2025 17:28
@tommusrhodus tommusrhodus self-requested a review January 7, 2025 11:32
Copy link
Contributor

@tommusrhodus tommusrhodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot change this option name, it's used internally by the theme mods system in WordPress.

Instead we should respond to the reviewer on this one with an explanation of what we're doing and why.

@rtio
Copy link
Member Author

rtio commented Jan 7, 2025

@tommusrhodus is this auto-generated or something internally? is due to that the reason the name follow this pattern?

@tommusrhodus
Copy link
Contributor

is this auto-generated or something internally?

Correct, the option name is theme_mods_{active theme slug}, so changing this format isn't possible.

@rtio
Copy link
Member Author

rtio commented Jan 7, 2025

nice. I assumed that but wanted to make sure I was thinking correctly. thanks @tommusrhodus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants