Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix live preview #106

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix live preview #106

wants to merge 2 commits into from

Conversation

roccotripaldi
Copy link
Member

@roccotripaldi roccotripaldi commented Jan 9, 2025 •
edited
Loading

Summary

The live preview works great when the current theme is a Tumblr theme. However, the live preview will break if the current theme is not a Tumblr theme.

To reproduce bug:

  1. Go to the installed themes page.
  2. Ensure you have a Tumblr theme downloaded.
  3. Ensure active theme is not a Tumblr theme.
  4. Click the Live Preview button on a Tumblr theme.
  5. The customizer will load up previewing a theme with unparsed blocks.

Screenshot 2025-01-09 at 4 18 31 PM

@tommusrhodus tommusrhodus marked this pull request as ready for review January 10, 2025 13:09
@roccotripaldi
Copy link
Member Author

Confirmed issue is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjbaptiste aaronjbaptiste Awaiting requested review from aaronjbaptiste

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roccotripaldi @tommusrhodus