Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dara: add margin in block editor #8594

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Dara: add margin in block editor #8594

merged 2 commits into from
Jan 22, 2025

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Jan 17, 2025

Fixes #6965.

Fixes #6611 on Dara theme.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Dara.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@pkevan pkevan changed the title Remove margin from figure css Dara: remove margin from figure css Jan 17, 2025
Copy link
Contributor

Theme-Check results

dara: There are required changes on the theme ❌.

❎ REQUIRED

  • Could not find wp_body_open action or function call at the very top of the body just after the opening body tag. See: wp_body_open
  • Tested up to: is missing from your style.css header. Also, this should be numbers only, so 5.0 and not WP 5.0
  • Requires PHP: is missing from your style.css header.
💡 RECOMMENDED (5)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
⚠️ WARNING (2)
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Headings'. Line 21: __( 'Headings' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Links'. Line 66: __( 'Links' ) );

@cbravobernal
Copy link
Contributor

Hi there!

There may be classic themes that are using the classic editor and do need that figure class. I took a slightly different approach to this one.

#8600

@cbravobernal cbravobernal added the [Type] Bug Something isn't working label Jan 21, 2025
@pkevan
Copy link
Contributor Author

pkevan commented Jan 21, 2025

Thanks @cbravobernal - i'll take a look!

@pkevan pkevan changed the title Dara: remove margin from figure css Dara: add margin in block editor Jan 21, 2025
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Dara [Type] Bug Something isn't working
Projects
None yet
3 participants