Assembler: Move the style variation specific font families from the main theme.json to the variation json file #8416
+676
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Move font families definition to the corresponding style variation. See #8079
Remove font families definitions from theme.json. See #8079
Preview changesI've detected changes to the following themes in this PR: Assembler. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
Theme-Check resultsassembler: No changes required ✅. |
|
I pulled these changes into #8421 to go with a number of typography improvements, to prevent conflicts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8079