Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loic: Add fix for SyntaxHighlighter max-width bug #8414

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Nov 13, 2024

Changes proposed in this Pull Request:

  • Ensure the .entry-content containers with SyntaxHighlighter blocks have a max-width set so the SyntaxHighlighter doesn't overflow.

Before

Screenshot 2024-11-13 at 10 55 09 AM

After

Screenshot 2024-11-13 at 10 54 40 AM

Related issue(s):

Fixes #8387

@sixhours sixhours added the [Type] Bug Something isn't working label Nov 13, 2024
@sixhours sixhours self-assigned this Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Preview changes

I've detected changes to the following themes in this PR: Loïc.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

loic/style.css Outdated

/*
* SyntaxHighlighter styles
* https: //github.com/Automattic/themes/issues/8387

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I noticed a space between https: and //. You might want to correct it for someone to copy and paste.

Copy link
Contributor

Theme-Check results

loic: No changes required ✅.

⚠️ WARNING (1)
  • Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is lo%c3%afc. (If this is a child theme, you can ignore this error.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loïc: syntax highlighter block breaks layout of page
2 participants