-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fall back login with username and password option to login #1656
Add fall back login with username and password option to login #1656
Conversation
📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charliescheer Just one minor note!!
Nice work BTW!!!
Header
- Launch Simplenote iOS
- Press on
Log In
- Press on
log in manually
As a result, you'll get the header Log in with email failed (...)
.
We should probably display no header here!
@jleandroperez Good call. Dropped the header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
Fix
We have received some feedback about the new login flow that some people thought we had dropped the login with password option. We have decided to add a button on the login with email page where users can choose to login with email and password instead. This surfaces this option for users who wants it and doesn't require receiving the login email to before you can enter your password. This also helps in circumstances where GAE might be down and login with email isn't possible.
Test
We'll email you a code to log in, or you can log in manually
Smoke test the magic links flow and make sure it still looks as expected
Review
(Required) Add instructions for reviewers. For example:
Release