Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fall back login with username and password option to login #1656

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

We have received some feedback about the new login flow that some people thought we had dropped the login with password option. We have decided to add a button on the login with email page where users can choose to login with email and password instead. This surfaces this option for users who wants it and doesn't require receiving the login email to before you can enter your password. This also helps in circumstances where GAE might be down and login with email isn't possible.

Login Login with pass

Test

  1. Clean install Simplenote
  2. On the onboarding page, tap on Sign up. Make sure that you see the username field and the terms and conditions info
  3. Go back, tap on Log In.
  • confirm that you see the option We'll email you a code to log in, or you can log in manually
  • Tap on that and confirm you are shown a login page with username and password fields
  • confirm that you can login from that page if you enter both pieces of info

Smoke test the magic links flow and make sure it still looks as expected

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added the [feature] login Anything relating to login. label Sep 11, 2024
@charliescheer charliescheer added this to the Future milestone Sep 11, 2024
@charliescheer charliescheer self-assigned this Sep 11, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 11, 2024

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1656-6909711-0191e9df-f662-4f38-ad06-a765c0809780
Version4.53
Bundle IDcom.codality.NotationalFlow.Alpha
Commit6909711
App Center BuildSimplenote - Installable Builds #375
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charliescheer Just one minor note!!

Nice work BTW!!!

Header

  1. Launch Simplenote iOS
  2. Press on Log In
  3. Press on log in manually

As a result, you'll get the header Log in with email failed (...).
We should probably display no header here!

@charliescheer
Copy link
Contributor Author

@jleandroperez Good call. Dropped the header

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

:shipit:

@charliescheer charliescheer merged commit 0bb4dd1 into trunk Sep 13, 2024
6 of 9 checks passed
@charliescheer charliescheer deleted the charlie/1654/magic-link-enter-password-button branch September 13, 2024 05:38
@mokagio mokagio modified the milestones: Future, 4.54 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] login Anything relating to login.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label to log in with email with option to use password log in
4 participants