Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 4.53 code freeze #1652

Merged
merged 18 commits into from
Sep 10, 2024
Merged

Merge 4.53 code freeze #1652

merged 18 commits into from
Sep 10, 2024

Conversation

wpmobilebot
Copy link
Collaborator

No description provided.

wpmobilebot and others added 14 commits September 4, 2024 01:44
@wpmobilebot
Bump version number
d518260
@wpmobilebot
Delete release notes source and localization before code freeze
41582ce
@wpmobilebot
Update draft release notes for 4.53.
2c1c48f
@wpmobilebot
Release Notes: add new section for next version (4.54)
8e08aae
@mokagio
Update release_notes.txt with copy for 4.53
47c8104
@mokagio
Update release_notes.txt with copy for 4.53 (#1651)
f788fe2
@mokagio
Fix a ensure_git_branch_is_release_branch! usage without !
abbf62d
@wpmobilebot
Freeze strings for localization
d804416
@wpmobilebot
Update metadata strings
d7cc1dc
@mokagio
Remove usage of undefined computed_release_branch_name
965846e 
See failure in
https://buildkite.com/automattic/simplenote-ios/builds/1100#0191bba6-0150-4b86-bf0f-1fdab906a02a
@mokagio
Revert previous localizations changes to retry CI code freeze completion
9f4ff12 
The CI code freeze completion failed, see
https://buildkite.com/automattic/simplenote-ios/builds/1100#0191bba6-0150-4b86-bf0f-1fdab906a02a

The previous commit, 965846e,
should fix the issue but in order to retry the full process to have an
authentic test, we need to reset the state.

As such, this reverts:

- d7cc1dc
- d804416
@mokagio @spencertransier
Remove outdated comment from start-code-freeze.yml
27f7fe6 
Co-authored-by: Spencer Transier <[email protected]>
@wpmobilebot
Freeze strings for localization
412c24c
@wpmobilebot
Update metadata strings
92fd936
@wpmobilebot wpmobilebot added this to the 4.53 milestone Sep 4, 2024
jleandroperez
jleandroperez approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator Author

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1652-a40e3f8-0191d4a9-690c-458f-bcfa-ec61f156719c
Version4.53
Bundle IDcom.codality.NotationalFlow.Alpha
Commita40e3f8
App Center BuildSimplenote - Installable Builds #362
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio merged commit edd1080 into trunk Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleandroperez jleandroperez jleandroperez approved these changes

Assignees
No one assigned
Labels
Releases
Projects
None yet
Milestone
4.53
Development

Successfully merging this pull request may close these issues.
4 participants
@wpmobilebot @dangermattic @jleandroperez @mokagio