-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release/4.52 into trunk #1645
Conversation
Generated by 🚫 Danger |
|
||
lane :lint_localizations do | ||
ios_lint_localizations(input_dir: APP_RESOURCES_DIR, allow_retry: true) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how this ended up inside a method 😳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooof. Nice catch.
Probably bad indentation at some point in the past tricked us, and then we ran rubocop -A
at some point later but didn't notice it despite being more obvious once indentation was fixed? 🤷
📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in Fastfile
LGTM 👍
|
||
lane :lint_localizations do | ||
ios_lint_localizations(input_dir: APP_RESOURCES_DIR, allow_retry: true) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooof. Nice catch.
Probably bad indentation at some point in the past tricked us, and then we ran rubocop -A
at some point later but didn't notice it despite being more obvious once indentation was fixed? 🤷
Merging
release/4.52
intotrunk
.Via intermediate branch
merge/release-4.52-into-trunk
, to help fix conflicts if any:@Automattic/apps-infrastructure this PR includes automation chances that I ported from WooCommerce iOS (see also woocommerce/woocommerce-ios#13793) as part of the ongoing release automation modernization for Simplenote (see also internal ref paaHJt-6Zx-p2). I'd appreciate a look, even though the fact that everything worked is already good proof of the validity of the changes. Thanks!
If no one gets to it before the time to start the next code freeze, I'll admin merge it.