Merge release/4.52 into trunk #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mokagio
commented
Aug 30, 2024
mokagio
commented
Aug 30, 2024
Comment on lines
-181
to
-184
|
|
||
| lane :lint_localizations do | ||
| ios_lint_localizations(input_dir: APP_RESOURCES_DIR, allow_retry: true) | ||
| end |
There was a problem hiding this comment.
Don't know how this ended up inside a method 😳
There was a problem hiding this comment.
Ooof. Nice catch.
Probably bad indentation at some point in the past tricked us, and then we ran rubocop -A at some point later but didn't notice it despite being more obvious once indentation was fixed? 🤷
|
| App Name |  Simplenote Prototype Build |
|
| Build Number | pr1645-15b4408-0191a32c-bfb3-4749-b9d5-a494d318a1aa | |
| Version | 4.52 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | 15b4408 | |
| App Center Build | Simplenote - Installable Builds #337 |
AliSoftware
approved these changes
Aug 30, 2024
Comment on lines
-181
to
-184
|
|
||
| lane :lint_localizations do | ||
| ios_lint_localizations(input_dir: APP_RESOURCES_DIR, allow_retry: true) | ||
| end |
There was a problem hiding this comment.
Ooof. Nice catch.
Probably bad indentation at some point in the past tricked us, and then we ran rubocop -A at some point later but didn't notice it despite being more obvious once indentation was fixed? 🤷
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging
release/4.52intotrunk.Via intermediate branch
merge/release-4.52-into-trunk, to help fix conflicts if any:@Automattic/apps-infrastructure this PR includes automation chances that I ported from WooCommerce iOS (see also woocommerce/woocommerce-ios#13793) as part of the ongoing release automation modernization for Simplenote (see also internal ref paaHJt-6Zx-p2). I'd appreciate a look, even though the fact that everything worked is already good proof of the validity of the changes. Thanks!
If no one gets to it before the time to start the next code freeze, I'll admin merge it.