Split building for ASC from uploading to TestFlight and run as separate CI steps #1635

mokagio · 2024-08-08T03:05:22Z

Fix

This will:

Ensure better retry-ability. If the TestFlight upload fails because of HTTP errors, we can retry that without rebuilding the whole ipa
Better CI resource management. The TestFlight upload does not need macOS, so it could run on a cheaper Linux box. This is not ready yet, but at some point we'll an agent optimized for running this kind of tasks.

Test

I tested this by triggering a release build on this branch:

Review

Only one developer or infrastructure engineer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

dangermattic · 2024-08-08T03:06:10Z

	1 Message
📖	This PR has the `Releases` label: some checks will be skipped.

Generated by 🚫 Danger

wpmobilebot · 2024-08-08T03:10:15Z

📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Prototype Build
	Build Number	pr1635-361cb27-019133cb-edb0-4b9f-bc39-01cd6eca409b
	Version	4.52
	Bundle ID	com.codality.NotationalFlow.Alpha
	Commit	`361cb27`
	App Center Build	Simplenote - Installable Builds #327

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio · 2024-08-08T04:27:26Z

.buildkite/commands/release-upload.sh

+echo "--- :closed_lock_with_key: Installing Secrets"
+bundle exec fastlane run configure_apply


This will become unnecessary for ASC uploads once we'll move to using env vars.

mokagio · 2024-08-08T04:30:05Z

fastlane/lanes/build.rb


-  version = beta_release ? ios_get_build_version : ios_get_app_version(public_version_xcconfig_file: VERSION_FILE_PATH)
+  version = beta_release ? build_code_current : release_version_current
  create_release(


I can see a further iteration where uploads to TestFlight and Sentry run in parallel, and we only create the release on GitHub when the TestFlight step has succeeded.

mokagio · 2024-08-08T08:20:48Z

fastlane/lanes/build.rb

-
-lane :build_for_app_store_connect do |fetch_code_signing: true|
-  appstore_code_signing if fetch_code_signing
-
-  gym(
-    scheme: 'Simplenote',
-    workspace: WORKSPACE,
-    configuration: 'Distribution AppStore',
-    clean: true,
-    export_method: 'app-store'
-  )
-end


This looks deleted but you'll find a few lines above with some additional parameters.

mokagio · 2024-08-08T08:21:51Z

fastlane/lanes/build.rb

  build_for_app_store_connect

+  upload_to_app_store_connect(
+    beta_release: beta_release,
+    skip_prechecks: skip_prechecks,
+    create_release: create_release
+  )


The lane build_and_upload_to_app_store_connect is now unused... I'd say we're better off deleting it. It sounds convenient for local usages, but we shouldn't do local builds unless in the most rare of occasions.

Agreed, let's delete it.

In the rare cases where we might need to do an App Store build from our local machines to debug stuff or unblock an automation bug, we can always call fastlane build_for_app_store_connect then fastlane upload_to_app_store_connect separately manually anway.

mokagio · 2024-08-08T08:22:44Z

fastlane/Fastfile

+PROJECT_ROOT_FOLDER = File.dirname(File.expand_path(__dir__))
+VERSION_FILE_PATH = File.join(PROJECT_ROOT_FOLDER, 'config', 'Version.Public.xcconfig')
+OUTPUT_DIRECTORY_PATH = File.join(PROJECT_ROOT_FOLDER, 'build', 'results')
+APP_STORE_BUNDLE_IDENTIFIER = 'com.codality.NotationalFlow'
+DEFAULT_BRANCH = 'trunk'


All these consts at the top were previously later on in the file I grouped them for clarity and because of the new imports that require them to be already defined.

This was prompted by the QR code being broken in recent PRs.

mokagio · 2024-08-08T11:07:00Z

fastlane/Fastfile

  # @called_by CI — especially, relies on `BUILDKITE_PULL_REQUEST` being defined
  #
-  def post_installable_build_pr_comment(app_name:, build_number:, url_slug:)
-    UI.message("Successfully built and uploaded installable build `#{build_number}` to App Center.")
+  def post_installable_build_pr_comment


These installable builds changes are obviously unrelated to the TestFlight CI flow, but I noticed that the QR code was broken so I chucked them in here.

AliSoftware

LGTM 👍

fastlane/Fastfile

fastlane/lanes/build.rb

AliSoftware · 2024-08-08T14:32:57Z

fastlane/lanes/build.rb

  build_for_app_store_connect

+  upload_to_app_store_connect(
+    beta_release: beta_release,
+    skip_prechecks: skip_prechecks,
+    create_release: create_release
+  )


Agreed, let's delete it.

In the rare cases where we might need to do an App Store build from our local machines to debug stuff or unblock an automation bug, we can always call fastlane build_for_app_store_connect then fastlane upload_to_app_store_connect separately manually anway.

Co-authored-by: Olivier Halligon <[email protected]>

mokagio added 4 commits August 7, 2024 16:46

Tidy for clarity: Use build_app alias instead of gym

d2a9dbf

Specify output folder and name when building for ASC

f71ac6b

Extract automation to upload to TestFlight into dedicated lane

5dd9989

Use Versioning module to read version for TestFlight upload

be1d9e7

mokagio added 2 commits August 8, 2024 13:13

Strip timestamp from xcarchive name

945e0ae

Define all Fastlane consts before importing the lanes...

9fe2ede

mokagio commented Aug 8, 2024

View reviewed changes

Split ASC build from upload in CI

4d7a230

mokagio force-pushed the mokagio/split-build-and-tf-upload branch from 03e9135 to daf3bc9 Compare August 8, 2024 04:33

Manually bump build code to test release automation

3f504a0

mokagio force-pushed the mokagio/split-build-and-tf-upload branch from daf3bc9 to 3f504a0 Compare August 8, 2024 05:57

mokagio added 2 commits August 8, 2024 16:21

Zip xcarchive in the same step it's generated

4af91c1

Manually bump build code to test release automation

e1209d9

mokagio commented Aug 8, 2024

View reviewed changes

mokagio changed the base branch from trunk to release/4.52 August 8, 2024 09:55

mokagio added 5 commits August 8, 2024 19:57

Use clearer upload_to_testflight alias over testflight

36c7ced

Configure TestFlight upload to also submit for beta review

d60768d

Manually bump build code

41b4001

Extract release_notes.txt full path to a constant

15ca67d

Pass required changelog to upload to TestFlight method

5d7562a

mokagio marked this pull request as ready for review August 8, 2024 10:35

mokagio requested a review from a team August 8, 2024 10:36

mokagio added this to the 4.52 ❄️ milestone Aug 8, 2024

mokagio added Releases tooling Related to anything that supports the building & maintaining of the project. labels Aug 8, 2024

Update Installable build annotation logic

b6ede03

This was prompted by the QR code being broken in recent PRs.

mokagio commented Aug 8, 2024

View reviewed changes

AliSoftware approved these changes Aug 8, 2024

View reviewed changes

mokagio and others added 2 commits August 9, 2024 06:59

Fix a couple of typos in documentation comments

3932d28

Co-authored-by: Olivier Halligon <[email protected]>

Delete redundant build_and_upload_to_app_store_connect lane

361cb27

mokagio enabled auto-merge August 8, 2024 21:03

mokagio merged commit 69ba2ae into release/4.52 Aug 8, 2024
7 of 10 checks passed

mokagio deleted the mokagio/split-build-and-tf-upload branch August 8, 2024 21:06

mokagio mentioned this pull request Aug 15, 2024

Fix broken localization automation in release branch #1639

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split building for ASC from uploading to TestFlight and run as separate CI steps #1635

Split building for ASC from uploading to TestFlight and run as separate CI steps #1635

mokagio commented Aug 8, 2024 •

edited

Loading

dangermattic commented Aug 8, 2024 •

edited

Loading

wpmobilebot commented Aug 8, 2024 •

edited

Loading

mokagio Aug 8, 2024

mokagio Aug 8, 2024

mokagio Aug 8, 2024

mokagio Aug 8, 2024

AliSoftware Aug 8, 2024

mokagio Aug 8, 2024

mokagio Aug 8, 2024

AliSoftware left a comment

AliSoftware Aug 8, 2024

		echo "--- :closed_lock_with_key: Installing Secrets"
		bundle exec fastlane run configure_apply

Split building for ASC from uploading to TestFlight and run as separate CI steps #1635

Split building for ASC from uploading to TestFlight and run as separate CI steps #1635

Conversation

mokagio commented Aug 8, 2024 • edited Loading

Fix

Test

Review

Release

dangermattic commented Aug 8, 2024 • edited Loading

wpmobilebot commented Aug 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AliSoftware left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mokagio commented Aug 8, 2024 •

edited

Loading

dangermattic commented Aug 8, 2024 •

edited

Loading

wpmobilebot commented Aug 8, 2024 •

edited

Loading