-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chatrix peeking w/ guest account #193
Conversation
I edited your description so that it contains Automattic/hydrogen-web#7 in verbatim, thus Github can create a link into that PR. |
1f54741
to
476875f
Compare
01065ad
to
e3ad0a3
Compare
…tes a guest session if necessary
476875f
to
a1e8b6c
Compare
The branch is now functional except the error that you see on the top ruining it asthetically. Guest user session isn't allowed to create a filter, hence this error. This brings us to the question of how does Hydrogen want to treat guest user session different than a regular one, and how is that best done, which is what I am currently exploring. I would prefer to do it within Chatrix for now, if possible, before we get to the topic of how does "guest user session" look like in Hydrogen. |
With more changes done in Automattic/hydrogen-web#7 this is now functional without the error in the screenshot above. Sync runs for guest user session and should, for cases when guest user session is used to join a room. |
…y when no session exists
f7fa2f0
to
dc1362b
Compare
Don't even try to restore last url when in single room mode
Here are some issues I found while trying this:
|
This issue has been fixed!
I haven't encountered this issue even once so need to reproduce it before I can debug it.
Remembering last session is part of the "last url restoring" functionality which is now disabled for single room mode. We also talked about how its safe to assume for Chatrix context to not have multiple sessions. Have you identified a use case which justifies support for multiple sessions in a single Chatrix instance? If so, can you help me with the user story for it? |
@psrpinto For point 3 above, if you have indeed identified the need for multiple sessions in a single Chatrix instance opposed to our assumption, can you please file an issue with the user story? We can handle that in a follow up PR. For now, I am taking this PR forward ✌️ |
Maybe this was related to the
I opened #200 to track this. |
This draft PR (not meant for merge) highlights the differences needed in Chatrix to make guest account peeking work.
This would require more changes than current's peeking PR to Hydrogen (Automattic/hydrogen-web#7) So this branch in Chatrix uses the linked branch in Hydrogen as its dependency for Hydrogen.
To run: Pull the branch and don't forget to
yarn install
andyarn build