Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH SVN dependency to CI scripts #59

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

sbarbosa
Copy link
Contributor

@sbarbosa sbarbosa commented Jan 2, 2025

See: GH Action failed logs

What and why? 🤔

We are getting an error on the Linting and Testing
GH action about a missing svn command:

bin/install-wp-tests.sh: line 152: svn: command not found
Error: Process completed with exit code 127.

The script bin/install-wp-tests.sh requires SVN to check out the WordPress plugin and install it, so we must add that dependency to the CI scripts.

Testing Steps ✍️

Code review, and check that the CI tasks are all green.

Review checklist

  • Run pnpm changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • New tests have been added

@sbarbosa sbarbosa requested a review from therocket-gr January 2, 2025 14:46
@sbarbosa sbarbosa self-assigned this Jan 2, 2025
Copy link
Contributor

@therocket-gr therocket-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbarbosa sbarbosa merged commit 5858422 into trunk Jan 2, 2025
3 checks passed
@sbarbosa sbarbosa deleted the fix/add-svn-ci-scripts branch January 2, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants