allow up to 16 external axes from the hardcoded limit of 6 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o only grab needed ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our workflow does not use mFIZ but external axes to program FIZ, plus a track and couple model moving motors means we already max out the hard limit on external axes which is currently 6. We need additional external axes for forthcoming projects so looked into extending the hardcoded max Axis Number.
This pr allows up to 16 external axes to be created and rigged in the UI, but as some robots have a hardware limit of 6 external axes (Kuka KRL, ABB Rapid..), also updates these post-processors to only use the first 6 external axes. The CSV/TSV post processor will export any of the maximum 16 rigged external axes.
note: I noticed that if rigging a single axis with Axis Number set to anything other than 1, the post-processed file wont be positionally correct, eg rigging a single axis as n°3 wont export it as E3, unless 2 other axes are rigged as 1 and 2, it will end up as E1. Easy workaround to add first 2 unused axes but might be worth patching later on.