Get processCcd.py working #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2020
fergusL
approved these changes
Mar 26, 2020
| config.repair.doCosmicRay=True | ||
| # We seem to be getting too many CR detections | ||
| # For now we can increase the max number of allowable CRs | ||
| config.repair.cosmicray.nCrPixelMax = 1000000 |
There was a problem hiding this comment.
created an issue (#10) to track discussion for this issue
|
|
||
| # Sometimes there are no initial source detections, causing errors | ||
| # Lowering this number gives more sources for PSF fitting (default 10) | ||
| config.detection.includeThresholdMultiplier = 5.0 |
There was a problem hiding this comment.
Created issue (#11) to track discussion for this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to enable processCcd.py to run without error.
We seem to be getting a large amount of cosmic ray detections. I'm not sure whether they are real or whether they correspond to hot pixels, or whether there is something wrong in the config at this point.
The PSF modelling seems a bit temperamental. Sometimes it throws an error that no sources are input into the PSF measuring code. Not sure why this is at the moment.