Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating scripts to take manual observations - WIP #207

Closed
wants to merge 8 commits into from
Closed

creating scripts to take manual observations - WIP #207

wants to merge 8 commits into from

Conversation

lspitler
Copy link
Member

No description provided.

@lspitler lspitler requested a review from Physarah September 11, 2020 07:02
@lspitler lspitler marked this pull request as draft September 11, 2020 07:03
JAAlvarado-Montes
JAAlvarado-Montes requested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@JAAlvarado-Montes JAAlvarado-Montes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the comment above, include headers={} to avoid POC's bug

JAAlvarado-Montes
JAAlvarado-Montes requested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@JAAlvarado-Montes JAAlvarado-Montes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@JAAlvarado-Montes
Added filter_name to move filterwheel and modified camera.take_observ…
8b237ed 
…ation to have headers={}

- Added filter_name argument to move all the filterwheels automatically
- Added headers={} inside camera.take_observation() to avoid a current bug in POCS
@JAAlvarado-Montes
Copy link
Contributor

JAAlvarado-Montes commented Sep 11, 2020 •
edited
Loading

I have made two changes to this PR, namely added headers={} to avoid a current bug in POCS and added a new function called move_all_cameras_to_filter to move all of the filterwheels to the same slot we want to use afterwards when using take_pics. Please review.

Cheers!

@lspitler lspitler requested review from danjampro and wtgee September 11, 2020 23:45
@lspitler
Copy link
Member Author

Thanks @JAAlvarado-Montes for the edits. Do we need to add a function that turns on cooling for the cameras?

@wtgee
Copy link
Collaborator

wtgee commented Sep 12, 2020

FYI, this is on hold for just a bit but all these parts will probably be incorporated.

@AnthonyHorton
Copy link
Member

Hopefully relevant to this:

panoptes/POCS#1003 & #208

@AnthonyHorton
Copy link
Member

I have made two changes to this PR, namely added headers={} to avoid a current bug in POCS...

That's a reference to this: panoptes/POCS#1002

@lspitler
Copy link
Member Author

closing as this is being done in new repo huntsman-bridge

@lspitler lspitler closed this Oct 28, 2020
@lspitler lspitler added the stale PRs that are stale label Oct 28, 2020
@JAAlvarado-Montes JAAlvarado-Montes deleted the day_flats_script branch January 17, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAAlvarado-Montes JAAlvarado-Montes JAAlvarado-Montes requested changes

@Physarah Physarah Awaiting requested review from Physarah

@AnthonyHorton AnthonyHorton Awaiting requested review from AnthonyHorton

@danjampro danjampro Awaiting requested review from danjampro

@wtgee wtgee Awaiting requested review from wtgee

Assignees
No one assigned
Labels
stale PRs that are stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lspitler @JAAlvarado-Montes @wtgee @AnthonyHorton