Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to astropy template #38

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

update to astropy template #38

wants to merge 26 commits into from

Conversation

lspitler
Copy link
Member

@lspitler lspitler commented Aug 30, 2020

Now using astropy cookie cutter version, hopefully.

A few lingering issues. Will link relevant commits here:

  • doc build seems to work, aside from the inheritance diagrams. Hope this is just a local install issue.
  • why isn't Travis working?

Will submit PR now as draft until @AnthonyHorton tests thoroughly. Let's see if travis works...

Test using astropy's preferred automation helper via:
tox -e test

@lspitler lspitler requested a review from AnthonyHorton August 30, 2020 07:49
@lspitler lspitler marked this pull request as ready for review August 30, 2020 07:49
This was referenced Aug 31, 2020
@lspitler
Copy link
Member Author

Probably need to modify travis files to better match current version used by astropy, e.g.:
https://github.com/astropy/astropy/blob/master/.travis.yml
https://github.com/astropy/package-template/blob/cookiecutter/.travis.yml

@lspitler
Copy link
Member Author

Alight the tests seem to pass without a need for changes in #39 . I created a fresh conda environment to test things and then ran:

cd gunagala_src_dir
git clean -xdf
pip install tox
tox -e test

Making this non-draft and ready for someone else to test and review.

@lspitler lspitler requested a review from danjampro October 27, 2020 01:14
@lspitler lspitler removed the request for review from danjampro December 20, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant