Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing doc #1417

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update contributing doc #1417

merged 1 commit into from
Jan 28, 2025

Conversation

grbIzl
Copy link
Contributor

@grbIzl grbIzl commented Jan 28, 2025

I've added more details about current dev process.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@grbIzl grbIzl added documentation Add documentation other PR/issue is related to third-party, scripts or other things which don't have definite label. labels Jan 28, 2025
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/substrate-ecdsa/src 67% 0%
pallets/inflation/src 90% 0%
precompiles/unified-accounts/src 100% 0%
pallets/static-price-provider/src 91% 0%
precompiles/xcm/src 69% 0%
pallets/dapp-staking/src 79% 0%
chain-extensions/types/assets/src 0% 0%
pallets/ethereum-checked/src 76% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/xc-asset-config/src 48% 0%
precompiles/assets-erc20/src 78% 0%
pallets/vesting-mbm/src 87% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
precompiles/sr25519/src 56% 0%
primitives/src 54% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking/src/benchmarking 95% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking/src/test 0% 0%
chain-extensions/pallet-assets/src 54% 0%
pallets/collective-proxy/src 94% 0%
precompiles/dapp-staking/src 89% 0%
precompiles/dapp-staking/src/test 0% 0%
precompiles/dispatch-lockdrop/src 83% 0%
pallets/price-aggregator/src 76% 0%
pallets/unified-accounts/src 81% 0%
pallets/collator-selection/src 87% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/dynamic-evm-base-fee/src 85% 0%
primitives/src/xcm 62% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
Summary 76% (3490 / 4605) 0% (0 / 0)

Minimum allowed line rate is 50%

@grbIzl grbIzl merged commit 84ced51 into master Jan 28, 2025
8 of 10 checks passed
@grbIzl grbIzl deleted the doc/updatecontributing branch January 28, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add documentation other PR/issue is related to third-party, scripts or other things which don't have definite label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants