Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 9 #120

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Drupal 9 #120

wants to merge 15 commits into from

Conversation

isholgueras
Copy link
Contributor

@isholgueras isholgueras commented Jun 7, 2023

Fixes #119

To test first in a stage environment.

I haven't modify the Drupal docroot to the web directory. Currently is in . and doesn't seem very ... good.

Are you all agree with moving all Drupal to web, move the config to ./config/sync and so forth, as the scaffold usually does?

@isholgueras isholgueras force-pushed the drupal-9 branch 2 times, most recently from eccebf3 to 5b21fa7 Compare June 7, 2023 13:58
@isholgueras isholgueras marked this pull request as draft June 7, 2023 14:00
@isholgueras
Copy link
Contributor Author

Converting to draft as I found an issue

D9 update custom modules and themes to D9  ready

Upgrade to D9

Re-sync config
@jonhattan
Copy link
Member

Just configured dev environment (branch: dev, domain: dev.asociaciondrupal.es) with docroot web/ and php 8.1.

You can reload dev database from prod backup with jenkins job AsociacionDrupalES-AED » reload-dev-db

@isholgueras isholgueras marked this pull request as ready for review October 8, 2023 10:36
@isholgueras
Copy link
Contributor Author

After an amazing job for @fjgarlin , the Upgrade to D9 is ready.

The steps, just to confirm, should be

composer install 
drush updb || true
drush updb
drush cim -y || true
drush cim
drush cr

After this, the environment should now be running on D9.

@fjgarlin
Copy link

fjgarlin commented Oct 8, 2023

There is also the need to define some environment variables first as we use these in the code

PAYPAL_ENVIRONMENT // 'live' or 'sandbox'
PAYPAL_LIVE_CLIENT_ID
PAYPAL_LIVE_CLIENT_SECRET
PAYPAL_SANDBOX_CLIENT_ID
PAYPAL_SANDBOX_CLIENT_SECRET

SWIFTMAILER_USERNAME // [email protected]
SWIFTMAILER_PASSWORD

Once deployed, we might need to set the fake value in the UI (XXXX-VALUE-SHOULD-BE-SET-VIA-ENV-VARIABLE) so that future drush cex don't contain the real username/passwords. This will be ok as we are overriding the values via the settings file, so setting a fake value via the UI is totally ok. This is a one-off and we'll never need to worry anymore about these values going to the config files.

@fjgarlin fjgarlin mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to D9
3 participants