Create likes #3
Open
Create likes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyFoster
requested review from
BlakeWilliams
and removed request for
BlakeWilliams
| @like = @post.likes.where(user_id: current_user.id).first_or_create | ||
|
|
||
| unless @like.save | ||
| puts @like.errors.inspect |
app/models/user.rb
Outdated
| has_many :posts, through: :likes | ||
|
|
||
| def likes?(post) | ||
| post.likes.where(user_id: id).any? |
There was a problem hiding this comment.
I think this could be: likes.find_by(post_id: post.id).present?
| end | ||
|
|
||
| def destroy | ||
| @like = @post.likes.where(user_id: current_user.id).destroy_all |
There was a problem hiding this comment.
This should be:
@like = current_user.likes.find_by(post_id: @post.id)
@like.destroy
head 204The first change because you always want to think about operating on the current users likes because if you don't, you could be operating on any like. You cover that case here but I feel like this format makes the behavior/intention more clear.
The head 204 is nice because you're saying there's no content to send down
| before_action :set_post | ||
|
|
||
| def create | ||
| @like = @post.likes.where(user_id: current_user.id).first_or_create |
There was a problem hiding this comment.
Same comment here, putting the focus on the current user.
AshleyFoster
commented
May 10, 2018
| @@ -9,5 +9,10 @@ class User < ApplicationRecord | |||
| validates :password, presence: true | |||
| validates :authentication_token, uniqueness: true | |||
|
|
|||
| has_many :posts | |||
| has_many :likes | |||
| has_many :posts, through: :likes | |||
There was a problem hiding this comment.
I'm not sure if this is what I want to be doing here?
AshleyFoster
force-pushed
the
master
branch
2 times, most recently
from
dd3a047 to
121314d
Compare
AshleyFoster
force-pushed
the
af-add-likes
branch
from
25f6254 to
1603329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up likes. I would like to be able to use the likes? method from the user model on the front end to correctly show whether the user has liked the specific post. I'm just not sure how to go about it.